stovmascript / react-native-version

:1234: Version your React Native or Expo app in a `npm version` fashion.
MIT License
579 stars 75 forks source link

Syntax Error while versioning iOS #52

Open aruldd opened 6 years ago

aruldd commented 6 years ago

PS F:\Shared Desktop\ROBOCRAZE\RnD\alphacare\hospital_app_react> yarn version --minor yarn version v1.6.0 warning ..\package.json: No license field info Current version: 0.1.0-beta question New version: error Invalid semver version question New version: 0.2.0 info New version: 0.2.0 $ react-native-version [RNV] Versioning Android... [RNV] Android updated [RNV] Versioning iOS... [RNV] SyntaxError: Expected "\"", "\'", "\\"", "\n", or [^\"] but "\" found.

After setting up post version hook, running the command yarn version --minor produces this error.

Platform: Windows 10

stovmascript commented 6 years ago

Looks similar to: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-372974523 and: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-385656056

stovmascript commented 6 years ago

@aruldd Is it possible you have manually set up some paths in your Xcode project file?

VinceBT commented 6 years ago

Found the issue, the problem comes from React Native made in Windows that will have backslashed paths inside pbxproj. It's not a problem from your package at all @stovmascript . Check strings that are like this:

"\"$(SRCROOT)/$(TARGET_NAME)\"",
or
"$(SRCROOT)\..\node_modules\react-xxxx",

and change them to

"$(SRCROOT)/$(TARGET_NAME)",
accordingly
"$(SRCROOT)/../node_modules/react-xxxx",
stovmascript commented 6 years ago

@VinceBT Awesome, I'll capture this message and print out something more meaningful.

stovmascript commented 6 years ago

@VinceBT I also suspect that it's more of an issue with react-native link because a newly initialized project doesn't have any $(SRCROOT) strings yet. Which would explain why everything worked for me in: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-383421578.

VinceBT commented 6 years ago

It's just because Windows uses \ instead of / for paths and when paths are written to pbxproj when using react-native link, they will contain backslashes, it still works when your compile on a Mac, but it will crash with the pbxproj-dom parser package that you use. You could maybe add a "Common issues" page on your README for future users.

VinceBT commented 6 years ago

@aruldd Tell us if it worked for you so @stovmascript can close

Maushundb commented 4 years ago

I'm getting this issue when running on Mac OSX, is that expected? I'm on 3.2.0

Maushundb commented 4 years ago

Yeah there seems to be some paths in pbxproj that cocoapods installs that has the windows syntax as well. Had to go in and edit them manually, now it works. This does happen on macs as well apparently, might wanna update docs.

stovmascript commented 4 years ago

Hmm, this seems like a bug with cocoapods, or even some specific packages. I'm wondering if we could find the offending upstream code and report it...

stovmascript commented 4 years ago

Or we could patch pbxproj-dom or find an alternative.

Maushundb commented 4 years ago

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

vladwhd commented 4 years ago

I have a more "funny" case. My error was "SyntaxError: Expected "\"", "\'", "\\"", "\n", or [^\"] but "\" found.", so I searched for \ in the project.pbxproj and the only place where it was present was

shellScript = "# Name of the resource we're selectively copying\nFILENAME=GoogleService-Info.plist\n\nBUILD_TYPE=$(echo ${CONFIGURATION} | sed -E \"s/\\s*(Release|Debug) \\s*//\")\nORIGINAL_PATH=${PROJECT_DIR}/${TARGET_NAME}/Firebase/${BUILD_TYPE}/${FILENAME}\nDESTINATION_DIR=${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app\n\n# Make sure the prod version of GoogleService-Info.plist exists\necho \"Looking for ${ORIGINAL_PATH}\"\nif [ ! -f $ORIGINAL_PATH ]\nthen\n echo \"No ${FILENAME} found for build type ${BUILD_TYPE}. Please ensure it's in the proper directory.\"\n exit 1\nfi\n\necho \"Will copy ${ORIGINAL_PATH} to final destination: ${DESTINATION_DIR}\"\n\ncp \"${ORIGINAL_PATH}\" \"${DESTINATION_DIR}\"\n";

So basically it failed parsing the shell script, which is kind of weird. I removed this script and the error was gone, so it's this indeed. I will change my script to fix this, but it shouldn't have happened in the first place.

fabricio0915 commented 4 years ago

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

your command line appers like this?

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \n../node_modules/react-native/scripts/react-native-xcode.sh\n";
sanjaypojo commented 4 years ago

Facing the same problem after adding a custom build script, have been using the library without any issues for a year, but stuck now. Lots of backslashes in the script to escape quotes and spaces, so not sure how to fix it.

EDIT: I've created an issue in pbxproj-dom to see if they have any ideas on a fix

sanjaypojo commented 4 years ago

Just to clarify though -- I'm facing this issue on macOS. Here's the exact error:

[RNV] SyntaxError: Expected ",", "/*", or [ \t\n\r] but "B" found.

EDIT: Managed to resolve the issue by checking through my build settings and removing some \ characters as suggested

otkach-yara commented 3 years ago

I have fixed this issue by moving the script, which caused the error, from project.pbxproj to separate .sh file and then just added a reference to that file. Also you should make your sh file executable by chmod +x script.sh

Screenshot 2021-05-18 at 17 53 52
bimusiek commented 1 year ago

In our case it was newest react with @sentry/react-native having offending lines in shell script (copied from official Sentry documentation about workaround for RN >0.69) Here is the working shell script line in case anyone needs it:

/bin/sh -c "$WITH_ENVIRONMENT '$SENTRY_CLI_PATH react-native xcode $REACT_NATIVE_XCODE'"
marcinniemirski commented 1 year ago

Here is the final version of working shellScript in Sentry v5 and RN v0.71

shellScript = "set -e\nexport SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\nSENTRY_CLI_PATH=\"../node_modules/@sentry/cli/bin/sentry-cli\"\n/bin/sh -c \"$WITH_ENVIRONMENT $SENTRY_CLI_PATH react-native xcode\n$REACT_NATIVE_XCODE\"\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";
n-ii-ma commented 1 year ago

I'm experiencing this issue with Sentry.

I suspect this line is causing the problem, but I don't know how to fix it:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nset -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE\\\"\"\n\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";

Any way to solve this?

alainib commented 1 year ago

i have the same error on MacOs now. any one fixed this please ?

erickgtzh commented 1 year ago

i have the same error on MacOs now. any one fixed this please ?

were you able to fix it?

29er commented 1 year ago

SyntaxError: Expected "\"", "\'", "\\"", "\n", or [^\"] but "\" found.

similar to above it was Sentry shell script. I am on a mac. shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport ....."

in several places I had to replace $WITH_ENVIRONMENT \\\ with $WITH_ENVIRONMENT \ and $REACT_NATIVE_XCODE\\\ with $REACT_NATIVE_XCODE\

Leslie-Wong-H commented 10 months ago

Faced the same issue with Mac. Resolved with changing

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target\\ Support\\ Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

to

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target' 'Support' 'Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

The key: \\ to ' ' Root reason - the file path with space in it.

moisesmiss commented 4 months ago

Faced the same issue with Mac. Resolved with changing

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target\\ Support\\ Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

to

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target' 'Support' 'Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

The key: \\ to ' ' Root reason - the file path with space in it.

This works form me, thanks!