search

stpettersens / gulp-debian

:tropical_drink: Gulp plug-in to create a Debian package.
https://libraries.io/npm/gulp-debian
Other
7 stars 10 forks source link

Take in care SemVer #19

Closed McGiverGim closed 6 years ago

McGiverGim commented 6 years ago

Hi! This is only a suggestion. The SemVer in npm marks the versions as X.Y.Z being Z a pach to the version that does not modify the behaviour of the library. In package.json a "~x.y.z" says that the Z can be changed and is not a problem because it is totally compatible.

The latest version 0.1.8 was not compatible with earlier versions (0.1.7 for example) and it broke all the builds that use this library because the new parameter is mandatory.

Is not a problem, I will change where I'm using it to add the new parameter (I think is important to have the copyright) but being a public library I think that the SemVer must be accomplished ;)

Thanks again for your work!!

stpettersens commented 6 years ago

The new parameter shouldn't be mandatory in my opinion. I will look into this on the weekend. This is an oversight on my part.

I agree with you on the breaking changes. SemVer will be adopted from 0.2.0.

On 18 Jan 2018 07:14, "Míguel Ángel Mulero Martínez" < notifications@github.com> wrote:

Hi! This is only a suggestion. The SemVer in npm marks the versions as X.Y.Z being Z a pach to the version that does not modify the behaviour of the library. In package.json a "~x.y.z" says that the Z can be changed and is not a problem because it is totally compatible.

The latest version 0.1.8 was not compatible with earlier versions (0.1.7 for example) and it broke all the builds that use this library because the new parameter is mandatory.

Is not a problem, I will change where I'm using it to add the new parameter (I think is important to have the copyright) but being a public library I think that the SemVer must be accomplished ;)

Thanks again for your work!!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stpettersens/gulp-debian/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsGV3zHCvJnjZbciDy5Kl3bTLoGKulks5tLu9RgaJpZM4Rie7J .

lucomsky commented 6 years ago

@stpettersens, copyright parameter is mandatory due to Debian policy. So try to check package without copyright by lintian -c package.deb

stpettersens commented 6 years ago

I want to allow some flexibility. If you want to make a fork that is more stringent to Debian policy go ahead.

IMO if the packages work without the copyright file I am going to allow it.

Debian policy compliance was not originally a priority of this project. Its good that you added copyright file functionality but I'd prefer to take the approach of strongly suggest rather than mandate. That's why I'm displaying a warning to the user but still making the parameter functionally optional.

Thanks for your feedback.

On 22 Jan 2018 13:27, "lucomsky" notifications@github.com wrote:

@stpettersens https://github.com/stpettersens, copyright parameter is mandatory due to Debian policy https://www.debian.org/doc/debian-policy/#copyright-information. So try to check package without copyright by lintian -c package.deb

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stpettersens/gulp-debian/issues/19#issuecomment-359422910, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsGdMk2fRJEdRZJ_Z2jw96P20Hv5XWks5tNIzTgaJpZM4Rie7J .

lucomsky commented 6 years ago

No problem. I just mentioned it ;-)

stpettersens commented 6 years ago

It has been agreed to use semantic versioning as of publish of gulp-debian@0.2.0. This issue has can now be closed.