search

stpl / redmine_wysiwyg

Redmine plugin that allows changing textile/default editor to wysiwyg.
10 stars 4 forks source link

Formatting sub-words causes escaped textile to appear in wiki view #4

Open ghost opened 9 years ago

ghost commented 9 years ago

When I attempt to use ckeditor to format a sub word, the textile replacement for that html comes through unescaped in plain view.

tried this: Thewordredisrednotblack. Made the word "red" in both cases (even one instance) red using wysiwyg.

And got this visually (all black) Theword %{color:#FF0000}red%isred %{color:#FF0000}not%black.

All I have to do to fix it, is add a space after the terminating "%". I see that the opening % does get a space added.

I should add that this isn't only in the preview, it's after you save and the content reloads or is edited.

Environment: Redmine version 2.5.2.stable Ruby version 2.0.0-p576 (2014-09-19) [x86_64-linux] Rails version 3.2.19 Environment production Database adapter Mysql2 SCM: Git 1.7.1 Filesystem

Redmine plugins: redmine_agile 1.3.4 redmine_bootstrap_kit 0.1 redmine_checklists 3.0.1 redmine_dashboard 2.3.3 redmine_jenkins 0.1 redmine_planning 0.7.6 redmine_time_tracker 0.9.8 redmine_wysiwyg 1.0.0 redmine_zenedit 0.0.2 synaxin synaxin commented an hour ago

in lib/html2textile.rb#72 I changed def make_quicktag_end_pair(wrapchar) stop_capture_and_write write([wrapchar]) end

to

def make_quicktag_end_pair(wrapchar) stop_capture_and_write write("#{wrapchar} ") end

And I see a space is added on terminating % now. I'm unsure how to test this so I can't do a merge request because it wouldn't be worth anything. The text is formatted, but with spaces added and I don't think there is anything you can do about that due to textile rules. But this would be acceptable trade off rather than the odd markup poking through the wiki view.

ghost commented 9 years ago

This causes disaster with nested formats (Bold Red Italic)