search

str0zzapreti / pytest-retry

A simple plugin for retrying flaky tests in CI environments
MIT License
29 stars 6 forks source link

removed _initrequest call from item and updated comments #27

Closed str0zzapreti closed 9 months ago

str0zzapreti commented 9 months ago

Performing some unrelated testing for xdist compatibility and noticed that this _initrequest() method call isn't necessary for the tests to pass, even with the older pytest 7 version I built this plugin on. I wasn't aware of the API changing and I distinctly remember being annoyed that I was unable to reset item fixtures without this call, so for now this will go out in a beta release until I'm certain it's actually unnecessary.

str0zzapreti commented 9 months ago

Confirmed that fixture reset is still required, test coverage was not sufficient to validate this so a new test will be added to the next version to prevent regressions

str0zzapreti commented 9 months ago

No good alternatives to _initrequest() call found for now. May revisit this again later