search

str4d / bitcore-lib-zcash

A pure and powerful JavaScript Bitcoin library
https://bitcore.io/
Other
11 stars 15 forks source link

Correcting addresses for multibyte versions #1

Closed karelbilek closed 7 years ago

karelbilek commented 7 years ago

Fixes https://github.com/str4d/insight-ui-zcash/issues/1

karelbilek commented 7 years ago

I am frankly curious how was insight working when the decoding of addresses was wrong the whole time; but it's possible it's done somewhere else in the code for the second time

str4d commented 7 years ago

@runn1ng thanks for this! See ebb8b5683aaa1276c4551116a9ca0af8557fa773 for the changes I had to make to get 2-byte prefixes working in Insight - but as the web UI was the only use-case I was testing, I obviously missed this instance.

karelbilek commented 7 years ago

Thanks