Closed ovnanova closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1a91483
) 39.47% compared to head (7f51ef6
) 39.47%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
line count is not 1:1
That doesn't matter; what is more important is that the line lengths are approximately the same (except for the manpage strings, where paragraphs are unwrapped). I'll give it a pass if necessary.
line count is not 1:1
That doesn't matter; what is more important is that the line lengths are approximately the same (except for the manpage strings, where paragraphs are unwrapped). I'll give it a pass if necessary.
gotcha. i think the manpage was where i was the most uncertain. the lines before that section are pretty close.
Looks great, thank you! I've pushed a commit that adjusts some line wrapping, removes trailing spaces, and fixes a couple of bugs (some
{reference-ids}
were translated, breaking them and causing Fluent to fall back to the English strings).
thank you, happy to help! glad it wasn't too bad, definitely felt that rush to make the release 😅
will remember this if more work is needed in the future.
line count is not 1:1
i think this could use another formatting pass but i think it's good otherwise.. lmk 👍