search

strakers / zendesk-drupal-webform

Adds the ability to create Zendesk tickets from Drupal Webforms
https://packagist.org/packages/strakez/zendesk-webform
MIT License
2 stars 4 forks source link

Error when setting requester_name to full name on the webform #30

Closed kkumaren closed 3 years ago

kkumaren commented 4 years ago

Describe the bug Error when setting requester_name to full name on the webform.

To Reproduce Steps to reproduce the behavior:

  1. Go to webform Emails/Handlers settings
  2. Click on Edit
  3. Select full name in the requester field
  4. Save the settings
  5. Go to the webform and submit the form

Expected behavior

Screenshots Screenshot from 2019-12-17 21-10-07

strakers commented 4 years ago

Hi @kkumaren, apologies for getting back to you so late on this. Thanks so much for reporting this, and I'll open a new branch to look into this issue.

strakers commented 4 years ago

Hi @kkumaren, thanks again. I reviewed your pull request and I see where the addition of the check for string was necessary. I also noticed a need to check to ensure that when the name is in array format, all the expected fields are present. For this reason I created a polyfill class to handle this.

I've created the pull request and will be reviewing this.

strakers commented 3 years ago

Resolved in v1.1.0