search

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.
BSD 3-Clause "New" or "Revised" License
49 stars 72 forks source link

[mongodb_store] add option to use already launched mongod #139

Closed furushchev closed 9 years ago

strands-jenkins commented 9 years ago

Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request.

cburbridge commented 9 years ago

It is "ok to test", which is a good thing since Jenkins has already tested this anyway...

https://github.com/strands-project/mongodb_store/blob/hydro-devel/mongodb_store/tests/message_store.test needs to be updated to include <param name="mongodb_use_daemon" value="false" /> otherwise the unittests fail.

furushchev commented 9 years ago

jenkins failed. I added default value to appended param.

furushchev commented 9 years ago

jenkins passed! If there is no problem, please merge.

marc-hanheide commented 9 years ago

This looks ok to me. @hawesie @cburbridge awaiting your final say on this.

cburbridge commented 9 years ago

Have tested locally and both the existing "start a new mongod instance" and the "use existing instance" appear to be working fine, so I'm happy with a merge.

furushchev commented 9 years ago

Thank you very much!