search

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.
BSD 3-Clause "New" or "Revised" License
49 stars 72 forks source link

[mongodb_log.py] add option to treat topic name arguments as regular expression #141

Closed furushchev closed 9 years ago

furushchev commented 9 years ago

In this PR, I added option that if given option arg -e with topic names, they are treated as regular expression.

e.g.:

if there are topics that I'd like to log:

/base_controller/joint_trajectory_action/goal
/face_detector/goal
/head_traj_controller/follow_joint_trajectory/goal
/head_traj_controller/joint_trajectory_action/goal
/head_traj_controller/point_head_action/goal
/head_traj_controller_loose/follow_joint_trajectory/goal
/head_traj_controller_loose/joint_trajectory_action/goal
/l_arm_controller/follow_joint_trajectory/goal
/l_arm_controller/joint_trajectory_action/goal
/l_arm_controller_loose/follow_joint_trajectory/goal
/l_arm_controller_loose/joint_trajectory_action/goal
... (and all ActionGoals)

then we can specify by:

rosrun mongodb_log mongodb_log.py -e '.*/goal'
strands-jenkins commented 9 years ago

Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request.

hawesie commented 9 years ago

ok to test

hawesie commented 9 years ago

@furushchev please can you rebase this on hydro-devel? (now I have merged your other PR)

furushchev commented 9 years ago

@hawesie OK. I rebased and now passed test! :yum:

hawesie commented 9 years ago

Thanks! I'll check this out later today :+1:

hawesie commented 9 years ago

This works for me. Nice update, thanks. One minor feature request is that it would be good to check conflicts between some options, e.g. the all topics option vs inclusion/exclusion.

furushchev commented 9 years ago

@hawesie Thanks a lot for merging! I'll implement later on your request. :+1: