search

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.
BSD 3-Clause "New" or "Revised" License
49 stars 72 forks source link

Addprojection #173

Closed hkaraoguz closed 7 years ago

hkaraoguz commented 8 years ago

Added projection option so that object fields with large sizes such as point clouds could be optionally omitted during querying for increasing performance. Also added additional check for new soma default message type soma_msgs since soma2_msgs will be changed to soma_msgs in the future soma releases.

marc-hanheide commented 8 years ago

Next time, please try to separate out code cleanup and functionality changes into 2 PRs, as it's hard to assess otherwise.

hkaraoguz commented 8 years ago

I have added the projection option as a new service in the latest commit.

hawesie commented 8 years ago

Thanks! Please can you also add a unit test for this? It should be reasonably simple to extend the tests that are there.

hkaraoguz commented 8 years ago

I have added unit tests for projection.

hkaraoguz commented 8 years ago

Any updates on this?

hawesie commented 8 years ago

It’s on my todo list. The list is a little long!

hkaraoguz commented 8 years ago

Ok! It was fortunate though that I just discovered another bug while working on sth else. Fixed it in the latest commit.

hawesie commented 8 years ago

:)

hkaraoguz commented 7 years ago

Hi, Any updates on this? Lars needs to use the latest version of SOMa. And it requires the version waiting for pull request. Thanks.

hawesie commented 7 years ago

Sorry for the delay. This all checks out locally.