search

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.
BSD 3-Clause "New" or "Revised" License
49 stars 73 forks source link

Question about recent change on querying with projection #211

Closed furushchev closed 6 years ago

furushchev commented 6 years ago

It looks the recent change on https://github.com/strands-project/mongodb_store/commit/1bd27aa73eb2bf9ec52ccba61af6e2ecef86037a just deleted the field for projection from QueryMsg and copied it to QueryWithProjection and querying with projection was already implemented before the change. Is there any rationale for creating new method especially for querying with projection? @hkaraoguz

hawesie commented 6 years ago

Hmm... good question. I'm afraid I'm been a bit overloaded recently and haven't been checking these as thoroughly as I should have been. @hkaraoguz is there a good motivation for the change?

hkaraoguz commented 6 years ago

As far as I remember this is done to maintain backward compatibility at that time. Discussion is here. But this change has happened almost 1.5 years ago. It is not very recent.

furushchev commented 6 years ago

@hkaraoguz @hawesie Thank you for answering.

I remember this is done to maintain backward compatibility at that time.

Got it, is this feature still actively used now, or can we mark it as deprecated?

hkaraoguz commented 6 years ago

@furushchev No problem. It is still active. It should be working.

furushchev commented 6 years ago

@hkaraoguz Thanks, got it. Sent a pull request to remove duplicated codes to keep codes simple and now it was merged. Now I close this issue.