search

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.
BSD 3-Clause "New" or "Revised" License
49 stars 72 forks source link

mongodb_store: encode utf-8 on filling rosmsg #213

Closed furushchev closed 6 years ago

furushchev commented 6 years ago

Querying messages including non-ascii unicode string inside fails on filling message data from mongodb BSON document with the error like below:

[ERROR] [WallTime: 1517718535.363565] [1498895536.545688] 'ascii' codec can't encode characters in position 7-26: ordinal not in range(128)

Since mongodb keeps data only with utf-8 encoding, I added a code to force encode unicode string as 'utf-8' byte string.

strands-jenkins commented 6 years ago

Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request.

strands-jenkins commented 6 years ago

Merge build triggered.

strands-jenkins commented 6 years ago

Merge build triggered.

hawesie commented 6 years ago

@bfalacerda I wonder if this is related to our weird string escape issue!

hawesie commented 6 years ago

ok to test

strands-jenkins commented 6 years ago

Merge build triggered.

furushchev commented 6 years ago

@hawesie Hi, I'm using the patched package for more than a month and have no problem. Do you have any comment? (If not I'll merge this PR)

hawesie commented 6 years ago

Please merge and I'll create a new release this week.

furushchev commented 6 years ago

@hawesie Thank you! Merged!