strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.

BSD 3-Clause "New" or "Revised" License

49 stars 73 forks source link

release with C++11 compatibility? #222

Closed bbferka closed 6 years ago

bbferka commented 6 years ago

Hi,

I was wondering if it would be possible to release libmongocxx_ros with the c++11=on set in the CMake? Would this introduce any unforeseen issues? We are planning on releasing our package as a binary for kinetic but it depends on monogcxx and needs C++11. As it currently is we migrated from 26compat to legacy, but we needed to compile it from source with the c++11 flags, otherwise we get undefined behavior, probably because of the C++11 ABI compatibility breaks

hawesie commented 6 years ago

@furushchev @marc-hanheide any thoughts? I have no objections.

furushchev commented 6 years ago

Since indigo has no c++11 support, we will have to release separately if needed, but for other things, It is ok to me. @bbferka Could you open a pull request? We have test codes so we can see how it goes if c++11 is enabled.

bbferka commented 6 years ago

@furushchev @hawesie thanks for looking into this. I'll open a PR with the changes. You are right. This might not work for indigo.

bbferka commented 6 years ago

223 adds the necessary flags.

furushchev commented 6 years ago

Solved by #223

furushchev commented 6 years ago

FYI, this issue is also addressed in #224 and #225