if compiler supports it use C++11

[bbferka]

added compilation flags for C++11

[furushchev]

@bbferka Thank you for sending a pull request! Just one question, is it possible to enable/disable c++11 features using something like if($ENV{ROS_DISTRO}) condition? I think it'd be the best if it is possible to disable this feature on indigo.

[bbferka]

@furushchev I guess that is also possible. Since indigo only works with Ubuntu 14.04, which comes with an old gcc, check_cxx_compiler_flag("-std=c++11" COMPILER_SUPPORTS_CXX11) would also simply result in building without c++11 for indigo; If you prefer the ROS_DISTRO solution I can change that.

[furushchev]

@bbferka Cool! I think it is enough just to add it as a comment to CMakeLists.txt that c++11 feature will be disabled in indigo.

[bbferka]

@furushchev sorry, I was mistaken. gcc 4.8 already has C++11 support. I will change my code to use the ROS_ENV env. var., and disable C++11 for indigo

[hawesie]

What about future releases? The current setup means we have to manually add each new ROS release that supports C++11. Wouldn't it be better to check the negative, e.g. if indigo then c++11 is disabled, else all other releases have it enabled?

[bbferka]

@hawesie you're right. I just changed the check;

[hawesie]

Tests pass. All is well. Thanks @bbferka

[furushchev]

@bbferka @hawesie Thanks too for interating from me 👍

[furushchev]

@hawesie Could you release the new version including this change? I think it is not a small change, so recommend to increment a major or minor version (more than usual updates).

[hawesie]

ok, it's on my list for today

[bbferka]

@furushchev @hawesie thanks for merging!

[hawesie]

Released:

• https://github.com/ros/rosdistro/pull/17955
• https://github.com/ros/rosdistro/pull/17958