[fix 2] Kinetic devel mongocxx c++11

strands-project / mongodb_store

MongoDB tools for storing and analysing runs of ROS systems.

BSD 3-Clause "New" or "Revised" License

49 stars 73 forks source link

[fix 2] Kinetic devel mongocxx c++11 #225

Closed bbferka closed 6 years ago

bbferka commented 6 years ago

replaced the lsb_release call, because it is not available on the build server;

hawesie commented 6 years ago

@bbferka please can you check the test outputs to confirm it's doing the right thing? (it looks ok to me)

bbferka commented 6 years ago

@hawesie it looks good. The problem is that it looked good here from the beginning, but the binaries are built differently on the ROS build farm. If that could be tested without releasing every time it would make our life much easier.

bbferka commented 6 years ago

@hawesie thanks for merging; could you please do a release so it builds on the ros build farm?

hawesie commented 6 years ago

https://github.com/ros/rosdistro/pull/18103 https://github.com/ros/rosdistro/pull/18104

bbferka commented 6 years ago

@hawesie This time it fixed it:). I installed from the nightly build and my errors are gone. Yay. Thanks for you patience on solving this issue. I will open a new PR adding the checks for all the supported Debian versions as well, just for the sake of completeness.