Open marc-hanheide opened 9 years ago
The scitos_pc_monitor
is akin to pr2_computer_monitor
in the pr2_robot
package. So if we are still going by the PR2 structure, then it should stay in this package.
The bringup launch files have become bloated. The base launch files should stay, as in pr2_bringup
package in the pr2_robot
.
How strandsified are our G5s? The chest camera is an addition, but is anything else? Maybe we could modify scitos_description
to remove the chest camera, and make it more generic. Then make an additional scitos_g5s_description
in some non-release strands place that extend the base.
I'm not sure how strandsified our robots actually are. I don't think there are any more of the same geometry out there (e.g. with the pan tilt on the head). That already is IMO a STRANDS-specific item. That said, we should definitely make our package names a bit more specific. Also, I agree to have two description packages:
scitos_g5_description
with just the base without any kinect stuff, and probably even making the head optional (but enabled by default)strands_g5_description
with the extra sensors and pan-tilt... Naming to be discussed.
But I see your point, maybe we should indeed keep this package to stay "in line" with the pr2 structure (your view @hawesie?).
I'm happy to stay in line. Also agreed on the splitting of descriptions.
I guess this is related to the splitting out of the launch files. strands_navigation.launch
, part of scitos_bringup
launches the scitos_2d_navigation
which I want to change to strands_movebase
. I'll do that after a split is complete.
This repository is also our main and quite convenient connection to metralabs. How is that handled in future if this repo is deleted??
IMO scitos_driver should fill that role. Is it possible to move tickets? On 19 Oct 2014 18:03, "Christian Dondrup" notifications@github.com wrote:
This repository is also our main and quite convenient connection to metralabs. How is that handled in future if this repo is deleted??
— Reply to this email directly or view it on GitHub https://github.com/strands-project/scitos_robot/issues/59#issuecomment-59654416 .
How far are we with this? Can someone please clear stuff that has been moved?
May I poke again: Does this need to be released for the marathon. I suppose not, but I lost track of this part. @hawesie @cburbridge ?
If we are using scitos_bringup
as the base launch file for our scitos robots then it should be released.
This is all done now, right? Ckose?
This repository shall be removed:
scitos_pc_monitor
should be moved toscitos_apps
(if it is scitos-specific; if it's not, but in general useful and doesn't exist in the ROS universe yet, I suggest to separate it out.)scitos_common
which also has a number of files in it that are specific to our robots, like theurdf
definitions with cameras and sensors. So it feels like the launch files actually would belong there? We might also consider changing the name of the packages to reflect that this is about our specific robot, e.gscitos_g5s_description
rather thanscitos_description
, but that's not crucial)CMakeLists.txt
for all packages and fix email, maintainer, etc. inpackage.xml
run_depend
should be filled forscitos_bringup
(I wonder if one could write a little script that digs through all the*.launch
files and figures out what package are needed...)@cburbridge I had your name against this repo, will you take care of it?