strands-project / scitos_robot

Everything related to the STRANDS robot hardware can go in here
0 stars 10 forks source link

refactoring and preparing release #59

Open marc-hanheide opened 9 years ago

marc-hanheide commented 9 years ago

This repository shall be removed:

@cburbridge I had your name against this repo, will you take care of it?

cburbridge commented 9 years ago

The scitos_pc_monitor is akin to pr2_computer_monitor in the pr2_robot package. So if we are still going by the PR2 structure, then it should stay in this package.

The bringup launch files have become bloated. The base launch files should stay, as in pr2_bringup package in the pr2_robot.

How strandsified are our G5s? The chest camera is an addition, but is anything else? Maybe we could modify scitos_description to remove the chest camera, and make it more generic. Then make an additional scitos_g5s_description in some non-release strands place that extend the base.

marc-hanheide commented 9 years ago

I'm not sure how strandsified our robots actually are. I don't think there are any more of the same geometry out there (e.g. with the pan tilt on the head). That already is IMO a STRANDS-specific item. That said, we should definitely make our package names a bit more specific. Also, I agree to have two description packages:

  1. a generic scitos_g5_description with just the base without any kinect stuff, and probably even making the head optional (but enabled by default)
  2. a STRANDS strands_g5_description with the extra sensors and pan-tilt...

Naming to be discussed.

But I see your point, maybe we should indeed keep this package to stay "in line" with the pr2 structure (your view @hawesie?).

hawesie commented 9 years ago

I'm happy to stay in line. Also agreed on the splitting of descriptions.

nilsbore commented 9 years ago

I guess this is related to the splitting out of the launch files. strands_navigation.launch, part of scitos_bringup launches the scitos_2d_navigation which I want to change to strands_movebase. I'll do that after a split is complete.

cdondrup commented 9 years ago

This repository is also our main and quite convenient connection to metralabs. How is that handled in future if this repo is deleted??

marc-hanheide commented 9 years ago

IMO scitos_driver should fill that role. Is it possible to move tickets? On 19 Oct 2014 18:03, "Christian Dondrup" notifications@github.com wrote:

This repository is also our main and quite convenient connection to metralabs. How is that handled in future if this repo is deleted??

— Reply to this email directly or view it on GitHub https://github.com/strands-project/scitos_robot/issues/59#issuecomment-59654416 .

marc-hanheide commented 9 years ago

How far are we with this? Can someone please clear stuff that has been moved?

marc-hanheide commented 9 years ago

May I poke again: Does this need to be released for the marathon. I suppose not, but I lost track of this part. @hawesie @cburbridge ?

hawesie commented 9 years ago

If we are using scitos_bringup as the base launch file for our scitos robots then it should be released.

marc-hanheide commented 9 years ago

This is all done now, right? Ckose?