search

strands-project / strands_movebase

A repository for all the STRANDS-augmented movebase, including 3D obstacle avoidance, etc.
MIT License
10 stars 20 forks source link

Always run `move_base` on the main pc. #14

Closed lucasb-eyer closed 9 years ago

lucasb-eyer commented 9 years ago

Currently, it was running on the same pc as the chest cam. This doesn't make sense to me (pointcloud is subsampled on the chest-cam, so traffic is no valid reason), and apparently hinders me from seeing its output.

In the same run, I gave the arguments more descriptive names. The renaming might break people's custom launchfiles. Renames that need to be made: 

- "with_camera"
+ "with_chest_xtion"
- "camera"
+ "chest_xtion_name"
- "camera_ip"
+ "chest_xtion_machine"
- "camera_user"
+ "chest_xtion_user"

Also needs strands-project/strands_systems#91 to happen together with it.

marc-hanheide commented 9 years ago

assessing the consequences of this is beyond me... please @Jailander @cdondrup @nilsbore have a look and enlighten me.

lucasb-eyer commented 9 years ago

I recommend reading commit-by-commit.

  1. Doesn't change anything
  2. Replaces a bigtime duplication, but shouldn't change any semantics either
  3. and 4. (didn't manage to cleanup git history, sry) Makes the actual thing: running move_base run on the main pc even if the chest is somewhere else.

Of course, I have tested it here for a few hours now, but I can't change my whole setup to "chest on localhost" just to test. It "should" just work, with the caveat being the renames in the first comment.