strands-project / strands_perception_people

long-term detection, tracking and recognition of people
96 stars 70 forks source link

Namespaces and topics specified as parameters. #218

Closed MFernandezCarmona closed 6 years ago

MFernandezCarmona commented 6 years ago

Also some other minor changes: people_tracker_filter/src/filter.cpp: changed method to acknowledge map reception. upper_body_detector: merged with ENRICHME branch, solves most of the memory problems.

marc-hanheide commented 6 years ago

can you check why this failed? See https://lcas.lincoln.ac.uk/buildfarm/job/Kpr__strands_perception_people__ubuntu_xenial_amd64/2/console

This is the problem:

15:11:34 CMake Error at CMakeLists.txt:2 (project):
15:11:34   The CMAKE_C_COMPILER:
15:11:34 
15:11:34     /usr/lib/ccache/cc
15:11:34 
15:11:34   is not a full path to an existing compiler tool.
15:11:34 
15:11:34   Tell CMake where to find the compiler by setting either the environment
15:11:34   variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
15:11:34   the compiler, or to the compiler name if it is in the PATH.
15:11:34 
15:11:34 
15:11:34 CMake Error at CMakeLists.txt:2 (project):
15:11:34   The CMAKE_CXX_COMPILER:
15:11:34 
15:11:34     /usr/lib/ccache/c++
15:11:34 
15:11:34   is not a full path to an existing compiler tool.
15:11:34 
15:11:34   Tell CMake where to find the compiler by setting either the environment
15:11:34   variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
15:11:34   to the compiler, or to the compiler name if it is in the PATH.

I recall a similar problem where the ROS dependencies have changes and one now needs to explicitly depend on roscpp or similar, I seem to recall.

MFernandezCarmona commented 6 years ago

Hi, Our fork was really maintained by @scosar. I will talk with him about your comments and corrections. I did use this with Kinect2, I will put more detailled description and probably an extra launcher later. Cheers

marc-hanheide commented 6 years ago

retest this please

marc-hanheide commented 6 years ago

@MFernandezCarmona I managed to fix the issues around ccache on the integration server, but there as indeed relevant issues still to be resolve, see https://lcas.lincoln.ac.uk/buildfarm/job/Kpr__strands_perception_people__ubuntu_xenial_amd64/12/console

18:32:10 [ 40%] Building CXX object CMakeFiles/upper_body_detector.dir/src/main.cpp.o
18:32:17 /tmp/catkin_workspace/src/strands_perception_people/upper_body_detector/src/main.cpp: In function ‘void callback(const ImageConstPtr&, const ImageConstPtr&, const ConstPtr&, const CameraInfoConstPtr&)’:
18:32:17 /tmp/catkin_workspace/src/strands_perception_people/upper_body_detector/src/main.cpp:294:33: error: too few arguments to function ‘float nanf(const char*)’
18:32:17        matrix_depth(c, r) = nanf();
18:32:17                                  ^
18:32:17 In file included from /usr/include/math.h:104:0,
18:32:17                  from /usr/include/c++/5/cmath:44,
18:32:17                  from /opt/ros/kinetic/include/ros/time.h:55,
18:32:17                  from /opt/ros/kinetic/include/ros/ros.h:38,
18:32:17                  from /tmp/catkin_workspace/src/strands_perception_people/upper_body_detector/src/main.cpp:2:
18:32:17 /usr/include/x86_64-linux-gnu/bits/mathcalls.h:228:14: note: declared here
18:32:17  __MATHCALLX (nan,, (const char *__tagb), (__const__));
lucasb-eyer commented 6 years ago

Thanks for adressing all these, and thanks again for merging back upstream!

The build failure is because I forgot that nanf() needs to be called as nanf("") instead, that should fix it.