search

strands-project / strands_systems

all system configs
0 stars 16 forks source link

Ability to include site-specific movebase parameters. #94

Closed lucasb-eyer closed 9 years ago

lucasb-eyer commented 9 years ago

Goes together with strands-project/strands_movebase#18

nilsbore commented 9 years ago

This looks OK to me, better to do it this way than to have to clone strands_movebase every time. But might I suggest to just load those parameters after also loading the default ones? That way you can just choose which parameters to swap out? The parameter server loads them sequentially and picks the last ones so that would work.

lucasb-eyer commented 9 years ago

Huh, I thought that I did exactly that?

lucasb-eyer commented 9 years ago

Yeah, look at the other PR, it's the very last param file that's loaded (in movebase) and I even added the comment saying exactly that in ALLCAPS ;-)

nilsbore commented 9 years ago

Aah, my mistake, didn't see that you didn't have the conditional tag for the other arguments. Looks good!