search

strands-project / strands_systems

all system configs
0 stars 16 forks source link

Pass-through the EBC port for docking. #95

Closed lucasb-eyer closed 9 years ago

lucasb-eyer commented 9 years ago

DEFAULT TO NONE, ONLY ONE ROBOT HAS A LIGHT IN THERE. Feels good to shout once in the morning.

See strands-project/scitos_apps#120

marc-hanheide commented 9 years ago

but this is a hack, right? We don't want this, but we want to fix https://github.com/strands-project/scitos_apps/pull/120!

marc-hanheide commented 9 years ago

I would suggest not to change it here, but in https://github.com/strands-project/scitos_apps/tree/hydro-devel/scitos_docking/launch. Doing it in here, just confuses people even more. Only people that HAVE a light should set it here.

lucasb-eyer commented 9 years ago

The problem is, I think, that people are not supposed to write their own full launchfiles but rather include strands_navigation.launch and friends and set parameters. Otherwise there is no reason for strands_*.launch to exist, is there?

marc-hanheide commented 9 years ago

yes, you're right. So this is indeed helping others as well. So, I agree, this is a useful addition, but not the correct solution to the problem in https://github.com/strands-project/scitos_apps/pull/120

But yes, happy to have this in!