strangelove-ventures / horcrux

A threshold Tendermint signer
Apache License 2.0
272 stars 93 forks source link

Metrics (signer_sentry_connect_tries/signer_total_sentry_connect_tries) #193

Open activenodes opened 1 year ago

activenodes commented 1 year ago
  "version": "3.1.0",
  "commit": "03f565d67bb5394a4b3017a1adb00561d5297724",

I simulated a sentry down for a few minutes (first one and then two), and then restored, but after hours the result is still this:

# curl -sS localhost:6011/metrics | grep sentry

# HELP signer_sentry_connect_tries Consecutive Number of times sentry TCP connect has been tried (High count may indicate validator restarts)
# TYPE signer_sentry_connect_tries gauge
signer_sentry_connect_tries 124
# HELP signer_total_sentry_connect_tries Total Number of times sentry TCP connect has been tried (High count may indicate validator restarts)
# TYPE signer_total_sentry_connect_tries counter
signer_total_sentry_connect_tries 124

What is the difference between signer_sentry_connect_triesand signer_total_sentry_connect_tries? Is it a bug?

Thanks

activenodes commented 1 year ago

Update. I’ve noticed that maybe the value signer_sentry_connect_tries is reset only if the signer is "used" by sentry and not just after restored connection. Could be this the reason and in case fixed?