Update nato thread reference

strangeparts / gasmask

MIT License

90 stars 13 forks source link

Update nato thread reference #13

Closed stephen304 closed 4 years ago

stephen304 commented 4 years ago

Changes include:

Removing redundant operations
Flipping the female thread so it looks upright
Tweaking the positioning so both threads are flat on the y plane
Add chamfer to outer edge of the female thread
Instead of cutting the male thread to shorten it, adjust the chamfer operation

stephen304 commented 4 years ago

I'm wondering if it would be good to also add a hole in the male thread with the recommended diameter since not having too thin walls are probably important for the seal on the gasket. So I may add that on to this before merging.

stephen304 commented 4 years ago

I added a 33mm hole in the male threads since that's what the spec suggests

stephen304 commented 4 years ago

@scottyallen I think this is ready to merge now if it looks good to you

scottyallen commented 4 years ago

Looks great!