strangeparts / gasmask

MIT License
90 stars 13 forks source link

Added a disclaimer and fixed a typo #2

Closed Ferferite closed 4 years ago

Ferferite commented 4 years ago

pla and other materials can be dangerous so I added a "heads up" about that.

stephen304 commented 4 years ago

Do you have more information about this? Should PETG be recommended? I have an idea to make a "Safety Checklist" in the readme that could mention things like this as well as other stuff like add a face sealing material, you need to assemble and install an exhale valve, what kinds of adhesive to use to seal the clear plastic with the frame, etc. Once more modular pieces are made we'll definitely want to add some assembly instructions as well.

Ferferite commented 4 years ago

Yes, PETG is recommended. Also for adhesive hot glue would be nice but you could also use 5 min epoxy to have more time setting everything.

stephen304 commented 4 years ago

I think we need more information on the risks of PLA if you have any resources. If the concern is about the mask being subjected to large impacts in a protest-type situation, then the warning could be more specific. For a non-protest situation, as a dust mask or a covid mask I'm not sure if the warning applies so maybe we can add that qualifier and suggest people evaluate the situation they plan on using it in to determine what material they should use.

Ferferite commented 4 years ago

My informatin comes from the other masks that can be found on thingeverse. For non-protest situations I guess it would be fine but still, one may fall(not too often tho). I do not have any resources but my main material for my 3D printer is PLA and I know har brutal it can be, also the 3D printing comunity is on the same note pretty much

stephen304 commented 4 years ago

Yep I've definitely heard the same thing, just trying to find the most reliable information possible because it sounds like Scotty doesn't want to completely discourage PLA if it has a valid use. How would PLA fail even in a non-protest scenario?

Ferferite commented 4 years ago

hmm, I dont think it can fail easily in anon-prostest scenario. I have a lot of prints around the house that get daily use, I even have a small number plate for my house that has been sitting outside for years and it didnt break or crack at all. Outside of getting hit by something or tripping I dont think PLA can break by itself witohout it being "challenged".

stephen304 commented 4 years ago

Gotcha that make sense. Just want to make sure I understand what you mean. I think if the disclaimer was tweaked to recommend PETG and Nylon and warn against using PLA where the mask would be subjected to impacts or otherwise stressed, then I think* Scotty would be likely to merge.

Ferferite commented 4 years ago

Yeah, will tweak it. Thank you! Any other disclaimers you have in mind that should be added?

stephen304 commented 4 years ago

I think a warning about making sure they have a vent port with a one-way valve would be good - the reasoning being that the dead space in the filter would result in rebreathing the same air if it doesn't vent to a different location, risking asphyxiation. I think we may add more safety warnings so maybe making it a security checklist with bullet points is good, but we can also do that later - not that important.

Ferferite commented 4 years ago

I will not modify anything for now. We shall see what other things come up

stephen304 commented 4 years ago

The other things that come to mind are asking people to fit test / seal test before using, and ensuring people use gaskets or an appropriate glue on all the connections that need to be airtight. I just don't know about those yet because we haven't done any fit testing so idk if we can recommend any specific procedure yet. And I don't think anybody has recommended any specific glues that we could use for connections that people don't plan on undoing (one person I think suggested hot glue or silicone but it would be good to figure out some specific recommendations since those are both very broad categories).

I don't see any reason to wait on adding safety warnings, at least for stuff we've figured out so far but it's up to you

Ferferite commented 4 years ago

True, I will add now the pla disclaimer and about the one-way valve.

stephen304 commented 4 years ago

Mind if I suggest some changes to your fork?

Ferferite commented 4 years ago

Sure, I do not mind at all. Please go ahead

stephen304 commented 4 years ago

I made a PR to your branch. I hope I didn't go overboard :sweat_smile: I like to be pretty thorough.

LukasFoukal commented 4 years ago

I agree with Stephen's changes, much clearer to read and understand. Also at some point I think we should make a nice pdf sheet with pictograms and stuff, but don't think we should do that now, since the design will probably change

Ferferite commented 4 years ago

Yeah, stephen's changes are better.

stephen304 commented 4 years ago

@Ferferite If you merge my PR on your branch it'll automatically update this PR. Or I can make a separate PR

Ferferite commented 4 years ago

Done I think, kinda new to github but I merged. Thank you for helping

stephen304 commented 4 years ago

I think I can fix the merge conflict if you'd like

Ferferite commented 4 years ago

Yes, would be perfect. And if you can, mind explaining what the conflict means?

stephen304 commented 4 years ago

While you were working on your fork, someone else fixed the same typo. Because 2 people separately edited the same parts, git doesn't know how to merge the changes. This one is pretty easy since I can just overwrite the other changes with this branch, but it requires using git on the desktop via command line (probably the gui app can do it too). I usually resolve this kind of thing by merging scotty's fork into this fork and fixing the conflict here, then git will be able to merge this fork back into scotty's fork without scotty having to deal with the conflict.

Ferferite commented 4 years ago

Ah, I see. So is there anything I have to do?

stephen304 commented 4 years ago

I made another pull request to your fork, so if you merge that, then this PR should be fixed

Ferferite commented 4 years ago

done, everything is fine now. Thank you!

stephen304 commented 4 years ago

Good work team :D

scottyallen commented 4 years ago

Overall, I like this. I think we should also expand on the disclaimer at the top, stating that this is still under development and testing, listing specific concerns we've identified with the design right now, stating directly that you should not wear this design in a real world situation yet, and that any testing you do should be in a controlled environment with someone else present. If you want to add this to this PR that would be awesome, otherwise I can take a stab at it in a separate PR.

Ferferite commented 4 years ago

Sure thing, will update it so the wording is a bit better and the fact that we are still working on a valve design

scottyallen commented 4 years ago

Looks good - thank you for making those additions!