strangerstudios / basic-user-avatars

Add an avatar upload field on frontend pages and on the Edit Profile screen so users and admins can manage custom profile pictures without Gravatar.
https://wordpress.org/plugins/basic-user-avatars/
39 stars 34 forks source link

version 1.0.6 issue #50

Closed seema84 closed 7 months ago

seema84 commented 3 years ago

Hello,

since the latest version the prioritization does not work properly for me anymore.

I also use this plugin: https://de.wordpress.org/plugins/minotar-minecraft-avatars/

Before the last update (1.0.6), the prioritization was like this:

Custom Avatar (Upload) > Minotar > Default Avatar

But now i cant add a Custom Avatar if a Minotar Avatar was found.

andrewlimaza commented 3 years ago

Hi @seema84

We try our best to ensure that updates don't cause conflicts like this. However, the Minotar Minecraft Avatars is outdated (Tested with WordPress 3.6) which may be causing issues as we're following the latest WordPress functions to handle avatars.

Can you please share a screenshot of your issue?

A temporary solution would be to rollback to version 1.0.5 instead.

seema84 commented 3 years ago

What screenshot do you need for the problem?

6675

seema84 commented 2 years ago

A possibility to set the priority (between gravatar and avatar uploaded on the page) would be helpful.

JarrydLong commented 1 year ago

Considering Minotar is no longer supported as it last received an update 9+ years ago, I'm not sure if this is something we're going to fix. If this becomes a more common issue among other, more updated plugins, we can investigate - however:

Looking at how we currently use our avatars, there are improvements/adjustments that can be made, including adding the Basic User Avatars option as a default option under the Avatar settings found under Settings > Discussion:

image

Implementing something like this allows us to give preference to a Basic User Avatars avatar over others, but doesn't entirely fix the problem that has been discussed in this issue (of one giving preference over the other one when another has been set etc)

seema84 commented 1 year ago

I'm not sure if it's really minotar (which works fine by the way). For me it looks more like the prioritization in Basic User Avatars. Something must have changed in 1.0.6. This concerns not only minotar but also gravatar.

andrewlimaza commented 7 months ago

I've run further tests and the issue seems to happen on V1.0.6 and other newer versions. The reason being is that the Minotar plugin is not compatible with other Avatar plugins. (It always shows the Minotar minecraft head regardless if I am using a custom avatar).

They are loading their code at the lowest priority available without it being filterable. You may need to tweak the Minotar code directly to support custom uploaded avatars from Basic User Avatars.

Please have a look at the add_filter( 'get_avatar', array( $this, 'get_minotar_avatar' ), 1, 5 ); filter within their plugin's code to create a compatibility between the two plugins as there is no easy way for us to filter it.

Thank you for understanding, I'm sorry about any inconvenience caused by this as it is out of our control.