search

strangerstudios / basic-user-avatars

Add an avatar upload field on frontend pages and on the Edit Profile screen so users and admins can manage custom profile pictures without Gravatar.
https://wordpress.org/plugins/basic-user-avatars/
39 stars 34 forks source link

File name for non-English users #82

Open murinp opened 3 months ago

murinp commented 3 months ago

The final file name is strange for non-English user name.

E.g. user "Karolína Mílová" generates file names "karolana-malova_avatar.jpg" rather than "karolina-milova_avatar.jpg".

Wouldn't be better to use something like $user->user_nicename which is already URL sanitized instead of $user->display_name in unique_filename_callback function?

https://github.com/strangerstudios/basic-user-avatars/blob/606d8a681bd1b3e3ed30518a195c1d407b3e422a/init.php#L538