strangerstudios / paid-memberships-pro

WordPress membership plugin to restrict access to content and charge recurring subscriptions using Stripe, PayPal, and more. Fully open source. 100% GPL.
https://www.paidmembershipspro.com
Other
465 stars 358 forks source link

upgrade broke site #1438

Open damelco opened 4 years ago

damelco commented 4 years ago

Describe the bug upgraded from 2.2.6 to 2.4.0 top level (checkbox) disappeared from "Required Level" on Page editor page, though selections still listed in Page table (addon) column.

To Reproduce upgrade plugin level appearance and functionality DOES return after downgrading back to 2.2.6

Screenshots attempted to add two screenshots got; Something went really wrong, and we can't process that file. Try Again.

Expected behavior probably self-evident

Isolating the problem (mark completed items with an [x]):

WordPress Environment

much custom code ... not sure what to look for in that this is purely a pmpro feature!
ideadude commented 4 years ago

Hi there. Sorry for taking so long to see this.

I am not sure what is happening for you here. Let me know if this is still happening or if you have more information on it.

A possibility: There was a rare issue where some MySQL settings allowed a level with ID = 0 to be created. We recently pushed out an update to avoid this. On those setups, it seemed to fail to auto-increment the level IDs, which caused issues with adding more levels among other things.

Can you check and see if that top level of yours is level ID 0? If so, we can't really fix it to allow the ID to be 0, it causes too many issues. But you can perhaps update the database to change that level ID to something else and also change the rows in the memberships_users table and memberships_pages and anywhere else so the membership_id is the same as the new ID you set.

Let me know if this makes sense and if it helps. If not, I need more information about your set up and how to recreate this. It's not happening on our dev setups.

damelco commented 4 years ago

thank you for reaching out Jason. I think I see the problem?

this site is using the Paid Memberships Pro - Multisite Membership Add On

is it possible that code in question is no longer querying the db honoring one of the constants;

whereas it did in v2.2.6 and prior? I think it is using the slave site's database artifacts prior to the merge?!

thanks again bro.

-DJ