search

strangerstudios / paid-memberships-pro

WordPress membership plugin to restrict access to content and charge recurring subscriptions using Stripe, PayPal, and more. Fully open source. 100% GPL.
https://www.paidmembershipspro.com
Other
460 stars 357 forks source link

Fix misspelled action hooks (deprecate and correct) #942

Open kimcoleman opened 5 years ago

kimcoleman commented 5 years ago

In the twocheckout-ins.php file, the word "recurring" is misspelled in two action hooks. These should be moved to the deprecated list and replaced in the handler with the correct spelling.

https://github.com/strangerstudios/paid-memberships-pro/blob/991993479b6df3217b4b80d2fb63f1fee970e300/services/twocheckout-ins.php#L463

and

https://github.com/strangerstudios/paid-memberships-pro/blob/991993479b6df3217b4b80d2fb63f1fee970e300/services/twocheckout-ins.php#L495

ideadude commented 5 years ago

We should at least add a do_action with the correct spelling for each of these.

Then we can in the short term leave the old do_action in place with a comment. We can update our deprecation stuff to handle cases like this and add these to it.

related https://github.com/strangerstudios/paid-memberships-pro/issues/940