strangerstudios / pmpro-add-name-to-checkout

Adds “First Name” and “Last Name” fields to the “Account Information” section of the Membership Checkout page when using Paid Memberships Pro.
https://www.paidmembershipspro.com/add-ons/add-first-last-name-to-checkout/
17 stars 23 forks source link

First Name and Last Name strings not translatable #26

Closed femiyb closed 2 years ago

femiyb commented 3 years ago

First Name and Last Name strings are not translatable. Probably wrong text domain

michaelbeil commented 3 years ago

A customer (ticket 324438) moderators only requested this:

I am using Loco translate to translate things I am seeing that need translating.

I have translated this add-on, some things are translating well, but the name and last name fields aren’t.

michaelbeil commented 3 years ago

A customer (ticket 324861) moderators only requested this:

I would like to have these fields (First name and Last Name) translated at the checkout page. They are well translated in PMPro plugin. Can we fix this easily? Changing code in the plugin?

ancapdeclaration commented 3 years ago

Still not translatable. In "pmpro-add-name-to-checkout.php" i changed "pmpro" to "pmpro-add-name-to-checkout" both on line 66 and 70. Then it worked.

michaelbeil commented 3 years ago

A customer (ticket 342169) moderators only requested this:

I have translated the .pot File in German and saved it as a .mo but the language at the front end does not change. can you help me? The WordPress site is set to german.

baezor commented 2 years ago

@ancapdeclaration I had the same issue. Your solution fixes it.