search

strangerstudios / pmpro-advanced-levels-shortcode

Build a beautiful membership levels page for Paid Memberships Pro using a customizable block or shortcode.
https://www.paidmembershipspro.com/add-ons/pmpro-advanced-levels-shortcode/
27 stars 25 forks source link

"Free" in compare_table in pmpro_level-price pmpro_level-current not translated #21

Closed accessallareas closed 4 years ago

accessallareas commented 7 years ago

Translation file seems to ignore the "Free" under the Membership Level name in compare_table view.

kimcoleman commented 4 years ago

These lines should be updated to the proper text domain for the Add On and not use a core PMPro outdated textdomain. https://github.com/strangerstudios/pmpro-advanced-levels-shortcode/blob/dev/templates/levels-compare_table.php#L37-L43

kimcoleman commented 4 years ago

There are actually a few places the textdomain is incorrect in this plugin. When working this issue the entire code in the Add On should be addressed and correct textdomain used.

michaelbeil commented 4 years ago

A customer sent in a support ticket (moderators only) with the following:

used the pmpro_advanced_levels shortcode and upon publishing the page see an English sentence: “Membership never expires”. Hmm … that string ain’t in glotdict. Happen to know cause I translated and manage the whole translation in Dutch. Please add.

kimcoleman commented 4 years ago

These strings are all now properly set up for translation using the plugin's text domain 'pmpro-advanced-levels-shortcode'.