strangerstudios / pmpro-approvals

Grants administrators the ability to approve/deny memberships after signup.
https://www.paidmembershipspro.com/add-ons/approval-process-membership/
19 stars 29 forks source link

Register Helper Fields showing multiple times depending on RH setup in Approval screen. #125

Closed andrewlimaza closed 4 years ago

andrewlimaza commented 4 years ago

Describe the bug The Approval's preview view shows duplicate Register Helper Fields and does not take into consideration some field attributes such as level or profile. We should support this.

To Reproduce Steps to reproduce the behavior:

  1. Create multiple fields that are for specific levels, for example a phone field that for level 1 shows on profile only and on checkout shows for level 3.
  2. Signup for level 3 that requires approval.
  3. As an admin, navigate to the approvals page and view the user's information.
  4. This will show the phone field twice.

Screenshots PMPro team see this thread - https://www.paidmembershipspro.com/forums/topic/more-information-duplicate-entry-found/#post-278320 (Not sharing actual image due to sensitive information).

Expected behavior This should take into consideration the level and profile attribute of the Register Helper Add On.

Isolating the problem (mark completed items with an [x]):

andrewlimaza commented 4 years ago

This has been fixed and merged in. Will be included in the next release.