strangerstudios / pmpro-approvals

Grants administrators the ability to approve/deny memberships after signup.
https://www.paidmembershipspro.com/add-ons/approval-process-membership/
19 stars 29 forks source link

Send approval admin notification emails to all users with the pmpro_approver role or pmpro_approvals capability. #179

Open ipokkel opened 1 year ago

ipokkel commented 1 year ago

Is your feature request related to a problem? Please describe. Only the default site administrator receives the admin_approved, admin_denied, and admin_notification_approval approval notification emails. In some cases, the responsibility to approve memberships is delegated to various user accounts by either assigning them the Membership Approver - pmpro_approver role or the Membership Manager - pmpro_membership_manager role that included the pmpro_approvals capability. These users do not receive these aforementioned emails.

Describe the solution you'd like All approval admin notification emails are sent to all users who have the pmpro_approver role or a role that has the pmpro_approvals capability.

Describe alternatives you've considered Sending a BCC copy to users with custom code - https://gist.github.com/andrewlimaza/1fefe6bcbd929c4bdb0648345a15ccc8

Additional context Moderators: #519363

ipokkel commented 1 year ago

Here's an example code recipe as proof of concept that should achieve this - https://gist.github.com/ipokkel/45992b04e1bccba2cfe412678241f347

andrewlimaza commented 7 months ago

While this is a good idea, I think we need to cross this type of bridge within core first and let site owners choose what email address to send PMPro emails to.

Thanks for sharing the gist, I am going to leave this issue open for reference and definitely recommend using that gist if customers ask for it.