search

strangerstudios / pmpro-approvals

Grants administrators the ability to approve/deny memberships after signup.
https://www.paidmembershipspro.com/add-ons/approval-process-membership/
19 stars 29 forks source link

No way to approve a member for a second subscription #71

Closed talkytoaster closed 2 years ago

talkytoaster commented 5 years ago

If a user already has an active membership, and then they want to have a second one, even though they are previously approved, there is no way to approve the second membership, only to revoke/reset their existing one! Even if you do reset the existing one, as soon as you approve either one again, the other stays unapproved.

So, this leaves them stuck in the Approve Membership admin panel...

andrewlimaza commented 5 years ago

Hey @talkytoaster

Are you using the Multiple Memberships Per User Add On?

talkytoaster commented 5 years ago

Hi Andrew,

Yes, I am... and the problem still exists.

andrewlimaza commented 5 years ago

I don't think the Approvals Add On is compatible with Multiple Memberships Per User at this time. I have added a new issue for this.

A temporary workaround my be to hide certain levels from a user until they purchase a level and gets approved for that level.

talkytoaster commented 5 years ago

Andrew,

That is what I am doing, they can't buy the add-on level until they have purchased the main membership... But, the second (add-on) level approval can't be actioned.... only the initial (main) membership one.

Regards, Martin --

Talkytoaster – Here to help with your Garmin OSM mapping needs…

Email: martin@talkytoaster.com Web: talkytoaster.co.uk, .com, .info & .me.uk Twitter: @talkytoaster Skype: talkytoaster.info Telephone (UK): +44 (0)1403 888 236 Telephone (US or Canada): +1 914 465 0078 – UK land-line calls charged at normal UK rates) – Calls from mobiles or from outside the UK may be higher

On Fri, 7 Jun 2019 at 07:21, Andrew Lima notifications@github.com wrote:

I don't think the Approvals Add On is compatible with Multiple Memberships Per User at this time. I have added a new issue for this.

A temporary workaround my be to hide certain levels from a user until they purchase a level and gets approved for that level.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/strangerstudios/pmpro-approvals/issues/71?email_source=notifications&email_token=ALSR4DKBPDZQSKEASPK4ND3PZH46LA5CNFSM4HBZQ5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXE6RZI#issuecomment-499771621, or mute the thread https://github.com/notifications/unsubscribe-auth/ALSR4DKSO2KC2ZUKRJYBU23PZH46LANCNFSM4HBZQ5SA .

andrewlimaza commented 5 years ago

Thanks for the feedback Martin, we're going to work through this in the near future. Unfortunately at this point in time the MMPU Add On isn't compatible with the Approvals Add On.

cipriantepes commented 5 years ago

Hey, guys, any status on this? I really need this feature on a membership site. It's the end of October and this is still not working.

talkytoaster commented 4 years ago

Any update on this, it is now over 10 months since I raised this issue, and nothing since.... This is still causing me problems.

ghost commented 3 years ago

Having similar problem in our Project. Any workaround?

michaelbeil commented 3 years ago

This question came up in a ticket in email support (ID 29135):

...if we have membership approval enabled, could we make approval required for subscription renewals as well as new subscriptions?

We have an Add On to add support for multiple memberships per user using just PMPro called Multiple Memberships Per User Plus Add On. That Add On works with just PMPro, but a lot of our other Add Ons including this one, aren't coded to understand what to do when a user has multiple membership levels at once. For example, the email marketing Add Ons are coded to remove users from "old" level lists when they switch levels, PMPro doesn't understand that you might be adding a level without removing the old one. All of our Add Ons have to be updated to support this and it's going to take time.

michaelbeil commented 2 years ago

This came up in ticket 449418 (moderators only):

We have a couple of add-ons active, namely Approvals Add On and Multiple Memberships per User.

So what is happening is when a member selects multiple levels on registration, the admin is approving only one level it seems, and the other level(s) are not visible to the admin in the approval screen. The db is waiting for approval on the other level(s) and because there is no approval workflow for the other pending member levels, the counter for approvals remains stuck.

I was able to replicate the issue by doing the following:

  1. Disable multiple memberships per user add-on,
  2. Select 1 level and complete registration
  3. Admin area shows 1 pending approval as expected
  4. Admin approves member request, counter resets to 0 as expected.

Then i re-activate multiple memberships per user add-on, follow the same workflow and select 2 levels, checkout. I approve the request in admin and the counter is now stuck and does not reset after approval.

andrewlimaza commented 2 years ago

For now, you can also pre-approve any approved members - https://gist.github.com/andrewlimaza/cc30cf628a31805a40fe62d14a2309ae

This will assume that if the user is approved for level 1, they will automatically be approved for any level thereafter that requires approval and mitigate the issue of toggling approval status for MMPU.

andrewlimaza commented 2 years ago

Here is a PR that's pending to be merged - https://github.com/strangerstudios/pmpro-approvals/pull/158 (You may try it out at any time).