Open mircobabini opened 3 years ago
I see why there's some unreachable code here: https://github.com/strangerstudios/pmpro-cancel-on-next-payment-date/blob/b01d1b068217d882b90ae4e54f5f2add132dd840/pmpro-cancel-on-next-payment-date.php#L112-L115
This is because we used to check $pmpro_next_payment_timestamp !== false in the past. But now the condition is not strinct: https://github.com/strangerstudios/pmpro-cancel-on-next-payment-date/blob/b01d1b068217d882b90ae4e54f5f2add132dd840/pmpro-cancel-on-next-payment-date.php#L81
$pmpro_next_payment_timestamp !== false
So... that code should be unreachable, because $pmpro_next_payment_timestamp != false && empty( $pmpro_next_payment_timestamp ) it's always false.
$pmpro_next_payment_timestamp != false && empty( $pmpro_next_payment_timestamp )
I see why there's some unreachable code here: https://github.com/strangerstudios/pmpro-cancel-on-next-payment-date/blob/b01d1b068217d882b90ae4e54f5f2add132dd840/pmpro-cancel-on-next-payment-date.php#L112-L115
This is because we used to check
$pmpro_next_payment_timestamp !== falsein the past. But now the condition is not strinct: https://github.com/strangerstudios/pmpro-cancel-on-next-payment-date/blob/b01d1b068217d882b90ae4e54f5f2add132dd840/pmpro-cancel-on-next-payment-date.php#L81So... that code should be unreachable, because
$pmpro_next_payment_timestamp != false && empty( $pmpro_next_payment_timestamp )it's always false.