Clean up the code for this add on - Githubissues

strangerstudios / pmpro-cancel-on-next-payment-date

Change membership cancellation in Paid Memberships Pro to set expiration for next payment date instead of cancelling immediately.

https://www.paidmembershipspro.com/add-ons/cancel-on-next-payment-date

8 stars 8 forks source link

Clean up the code for this add on #20

Closed sc0ttkclark closed 3 years ago

sc0ttkclark commented 3 years ago

All Submissions:

[x] Have you followed the Contributing guidelines?
[x] Does your code follow the WordPress' coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This work includes:

Added phpdoc info for parameters and return statements, did not include @since in this work though
Used $wpdb->prepare when necessary
Used $wpdb->update when necessary
Simplified conditionals to return early
Made code generally more readable where possible

How to test the changes in this Pull Request:

General functionality testing to ensure all of the plugin features work as expected

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you successfully run tests with your changes locally?

Changelog entry

Updated code with newest coding standards and practices

sc0ttkclark commented 3 years ago

Best reviewed without whitespace changes https://github.com/strangerstudios/pmpro-cancel-on-next-payment-date/pull/20/files?w=1