Ensuring timestamps passed to date() are ints - Githubissues

strangerstudios / pmpro-cancel-on-next-payment-date

Change membership cancellation in Paid Memberships Pro to set expiration for next payment date instead of cancelling immediately.

https://www.paidmembershipspro.com/add-ons/cancel-on-next-payment-date

8 stars 8 forks source link

Ensuring timestamps passed to date() are ints #25

Closed dparker1005 closed 1 year ago

dparker1005 commented 2 years ago

All Submissions:

[x] Have you followed the Contributing guidelines?
[x] Does your code follow the WordPress' coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Now ensuring that timestamps passed to date() and date_i18n() are integers.

Based off of this wp.org ticket: https://wordpress.org/support/topic/php-error-log-warning-date-expects-parameter-2-to-be-int/

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

michaelbeil commented 2 years ago

A customer sent in a ticket (ID 372106) that is seeing this warning, so I sent them the fix for this.

mircobabini commented 2 years ago

Resolves #26.