strangerstudios / pmpro-cancel-on-next-payment-date

Change membership cancellation in Paid Memberships Pro to set expiration for next payment date instead of cancelling immediately.
https://www.paidmembershipspro.com/add-ons/cancel-on-next-payment-date
8 stars 8 forks source link

Date in cancellation text not localized. #28

Closed ipokkel closed 2 years ago

ipokkel commented 2 years ago

Describe the bug If you translate the confirm Message of the pmpro-cancel-on-next-payment-date plugin, the Date will not be translated in the local language:

English: Your recurring subscription has been cancelled. Your active membership will expire on %s.

German Translation: Deine Membership wurde gekündigt. Deine aktive Membership endet am 1. January 2022.

The Date still is in English with “January” instead of German “Januar”.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings > General and set the Site Language option to Deutsch and save settings
  2. In a private/incognito browser window log in as a user that is subscribed to a recurring membership level.
  3. Navigate to the Membership Account page and click on the link to cancel the membership subscription.
  4. Confirm cancellation.
  5. Observe that the date is still in English instead of the set site language.

Expected behavior The cancellation text should show the i18n date.

Isolating the problem (mark completed items with an [x]):

michaelbeil commented 2 years ago

@ideadude this PR was closed, so the cancellation text string didn’t get internationalization for the date.