strangerstudios / pmpro-gift-aid

Add a Checkbox to Opt In to the UK "Gift Aid" Tax-Incentive on Membership Checkout.
https://www.paidmembershipspro.com/add-ons/gift-aid/
GNU General Public License v3.0
1 stars 10 forks source link

* Add compatibility for v3.1 checkout page #18

Closed MaximilianoRicoTabo closed 2 weeks ago

MaximilianoRicoTabo commented 3 weeks ago
image

All Submissions:

Changes proposed in this Pull Request:

Add the gift aid checkbox on pmpro_checkout_boxes action. Tweak the pmproga_pmpro_checkout_after_level_cost function a bit.

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

kimcoleman commented 3 weeks ago

@MaximilianoRicoTabo please update this to use a structure more like https://github.com/strangerstudios/pmpro-payment-plans/blob/dev/pmpro-payment-plans.php#L436-L449. This should be a fieldset. We also need to us the <h2>tag, not <h3> here for accessibility / no skipped heading levels.

There is no "pmpro_normal" selector in our CSS.

The best way to see how a single checkbox filed should be shown is to add one in User Fields and reflect that same markup.

<div id="checkbox_field_div" class="pmpro_form_field pmpro_form_field-checkbox">
    <label class="pmpro_form_label pmpro_form_label-inline pmpro_clickable" for="checkbox_field">
        <input name="checkbox_field" type="checkbox" value="1" id="checkbox_field" checked="checked" class="pmpro_form_input pmpro_form_input-checkbox">
        Checkbox Field
    </label>
</div>
MaximilianoRicoTabo commented 3 weeks ago

done @kimcoleman