[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
The redesign of the Membership Levels page + templates are slated for PMPro v2.9. We are including Gift in the template list. This PR updates the Gift Membership section to match the v2.9+ format for the levels admin page.
v2.9 adds new hooks so that Add Ons like this can place their settings in more places on the edit page. I have conditionally used the new hook to show this box right below the expiration settings of that new UI.
For sites that are not on 2.9, the settings section will be shown as it is today at the bottom of the page.
Note that the appearance is a bit less than perfect since the new format relies on CSS in core PMPro v2.9+. I think rather than replicate this formatting or code to variations of the section we add based on PMPro version we just live with this less than desirable look and believe that people will upgrade core.
How to test the changes in this Pull Request:
Check out the pending PR for the 'edit-levels-templates-cycle' from my GitHub user.
Go to Settings > Levels. Click Add New.
You'll see the "Gift" template. Click that.
On the Edit page, see the "Gift Membership" section right below the "Expiration Settings" section.
Other information:
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run tests with your changes locally?
Changelog entry
ENHANCEMENT: Added Gift level template and support for PMPro v2.9+ settings UI.
Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.
All Submissions:
Changes proposed in this Pull Request:
The redesign of the Membership Levels page + templates are slated for PMPro v2.9. We are including Gift in the template list. This PR updates the Gift Membership section to match the v2.9+ format for the levels admin page.
v2.9 adds new hooks so that Add Ons like this can place their settings in more places on the edit page. I have conditionally used the new hook to show this box right below the expiration settings of that new UI.
For sites that are not on 2.9, the settings section will be shown as it is today at the bottom of the page.
Note that the appearance is a bit less than perfect since the new format relies on CSS in core PMPro v2.9+. I think rather than replicate this formatting or code to variations of the section we add based on PMPro version we just live with this less than desirable look and believe that people will upgrade core.
How to test the changes in this Pull Request:
Other information:
Changelog entry