Fixed seats wasn't updating checkout pricing

strangerstudios / pmpro-group-accounts

Sell memberships to corporate organizations, families, teams, or any group of people where one member pays for a collection of people to access your content individually.

https://www.paidmembershipspro.com/add-ons/group-accounts/

0 stars 5 forks source link

Fixed seats wasn't updating checkout pricing #7

Closed andrewlimaza closed 9 months ago

andrewlimaza commented 9 months ago

BUG FIX: Fixed an issue where the fixed price settings wasn't adjusting the pmpro_checkout_level correctly.

dparker1005 commented 9 months ago

@andrewlimaza Do you have steps to replicate the issue? Some previous bug fixes may have addressed this behavior. $_REQUEST['pmprogroupacct_seats'] should always be set for group levels, regardless of the pricing model used.

andrewlimaza commented 9 months ago

When I set it to be "fixed" seats as an option the checkout pricing didn't update to the level cost + seat cost total so I made adjustments.

I'll try again shortly and let you know.

andrewlimaza commented 9 months ago

So after testing, this is more a visual change to show the total price on checkout page load for fixed seats + pricing. Without this PR checkouts still work as intended.

It actually may be a bit confusing including this fix. It would show the membership price + (seat * seat price) in the checkout text and then further down that the 2 seats they're purchasing are $5 each for example. Confusing.

I don't think this should be included anymore as checkout works correctly and this makes things more confusing due to the additional helper text. I'm going to close this PR.