search

strangerstudios / pmpro-membership-maps

Works with Paid Memberships Pro and the Member Directory Add On to add maps to the directory and profiles.
https://www.paidmembershipspro.com/add-ons/membership-maps/
2 stars 8 forks source link

pmpromm_override_first_marker can not be set to true #46

Closed DannyCooper closed 2 years ago

DannyCooper commented 2 years ago

https://github.com/strangerstudios/pmpro-membership-maps/blob/70adf81a8a4751a171bd9e1985e5eec0aa13b187/pmpro-membership-maps.php#L75-L83

I'm try to set override_first_marker_location to true in this way:

add_filter( 'pmpromm_override_first_marker', '__return_true' );

But when it's localized it gets converted into "1" or "true" which fails the strict comparison (===).

https://github.com/strangerstudios/pmpro-membership-maps/blob/70adf81a8a4751a171bd9e1985e5eec0aa13b187/js/user.js#L10

JarrydLong commented 2 years ago

This has been fixed and is available and working in V 0.3