search

strangerstudios / pmpro-pay-by-check

Add a "Pay by Check" option to PMPro levels, and keep members in "pending" status until an admin changes the order status.
https://www.paidmembershipspro.com/add-ons/pmpro-pay-by-check-add-on/
11 stars 27 forks source link

Conflict when using with Recurring Payment Email Reminders Add On #101

Open kimwhite opened 1 year ago

kimwhite commented 1 year ago

Describe the bug Members who create a subscription with Pay by Check are getting Recurring Payment Email Reminders, which are not appropriate for check payments. The user should only receive the default check_pending_reminder.html and not the membership_recurring.html from the Recurring Payment Email Reminders Add On.

To Reproduce Steps to reproduce the behavior:

  1. Install Pay by Check and Recurring Payment Email Reminders
  2. Checkout with for recurring payments by check
  3. Check user gets the reminder email like Card users..

Expected behavior When paying by Check, Members should only get the Pay by Check reminder.

Until this is updated adding this gist to your site will stop these unwanted reminders. https://gist.github.com/ipokkel/1ea35c55439f07ccc34265ff117a239d

andrewlimaza commented 1 year ago

I'm on the fence with this request, I can see cases where you'd want more than one reminder (even with the Pay By Check reminder going out).

That gist is a good way to disable it if you don't want to send out reminders to members paying via check - BUT, I also suggest in setting the Email Reminders frequency to not be the same as the Pay By Check reminder if you still want more than one reminder to go out to your members.