[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
Fixed issue in PMPro v3.0+ where recurring orders could be created for old Check orders even if the last payment was from a different payment gateway.
This means that if a user paid by check and then switched to paying with Stripe, recurring check orders could still be created in pending status and, if not marked as success, the user's membership could be canceled.
The change in PMPro v3.0 that brought about this issue was the removal of the cancelled status. The query fix by this PR only looks for orders in pending or success status to create a recurring order for, and since orders for old memberships were in cancelled status previously, recurring orders would not be created for them. Now that all cancelled orders are now success, this safeguard no longer works.
The fix in this PR changes the query to say "Only create recurring order if there is an old Check order that does not have orders from ANY gateway following it".
The fact that all orders are now success means that this query is now a lot less performant. We want to update this Add On to utilize Subs Table ASAP to both fix edge cases and improve performance.
Other information:
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run tests with your changes locally?
Changelog entry
Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.
All Submissions:
Changes proposed in this Pull Request:
Fixed issue in PMPro v3.0+ where recurring orders could be created for old Check orders even if the last payment was from a different payment gateway.
This means that if a user paid by check and then switched to paying with Stripe, recurring check orders could still be created in
pendingstatus and, if not marked assuccess, the user's membership could be canceled.The change in PMPro v3.0 that brought about this issue was the removal of the
cancelledstatus. The query fix by this PR only looks for orders inpendingorsuccessstatus to create a recurring order for, and since orders for old memberships were incancelledstatus previously, recurring orders would not be created for them. Now that allcancelledorders are nowsuccess, this safeguard no longer works.The fix in this PR changes the query to say "Only create recurring order if there is an old
Checkorder that does not have orders from ANY gateway following it".The fact that all orders are now
successmeans that this query is now a lot less performant. We want to update this Add On to utilize Subs Table ASAP to both fix edge cases and improve performance.Other information:
Changelog entry