Restricts content for non-members set with membership shortcode

[ipokkel]

Describe the bug When content is set for non-members using the membership shortcode, e.g. [membership level="0"]Display for non-members[/membership] the pmpropbc_pmpro_member_shortcode_access function removes access for non-members due to a check for active membership levels for the current user.

To Reproduce Steps to reproduce the behavior:

1. Go to Pages > Add New and create a new page containing the shortcode [membership level="0"]Display for non-members [/membership] and publish the page.
2. In a new private/incognito browser navigate to this page as a non-logged-in visitor
3. See error

Expected behavior The content inside the membership shortcode should be filtered according to the level parameter

Isolating the problem (mark completed items with an [x]):

• [x] I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• [x] This bug happens with a default WordPress theme active, or Memberlite.
• [x] I can reproduce this bug consistently using the steps above.

[michaelbeil]

As reported in ticket 433246 (moderators only).

When we have the pay by check plugin activated, the custom membership levels page shows blank for expired or new members. Only members with an active level can see the custom membership levels again. I currently have the pay by check deactivated but do still have the fix in our customizations plugin, it just isn’t working any longer.

I sent them the PR which fixed it.