search

strangerstudios / pmpro-recurring-emails

Send email in advance of recurring payments made to remind members of upcoming invoices.
https://www.paidmembershipspro.com/add-ons/recurring-payment-email-reminders/
10 stars 17 forks source link

Recurring notification has renewal date of January 1, 1970 #24

Open rschletty opened 2 years ago

rschletty commented 2 years ago

I am using the "Recurring Emails Add On" at mnsongwriters.org. I have a ticket going with PMPro Support. I am a Plus member. My support person has been of little help so far in ferreting out the code bug that results in showing a renewal date of January 1, 1970 in the recurring email notification. Here is a typical "live" message as received by a member:

“This is just a reminder that your Auto-Renewing Subscription $50/year membership will automatically renew on January 1, 1970.”

The variable !!enddate!! is used in the template “Membership level recurring payment”.

michaelbeil commented 2 years ago

@rschletty I am working with you on your ticket to troubleshoot this. I hope we can figure out what’s happening soon.

rschletty commented 2 years ago

Much thanks, Michael. We have been perplexed by this for about 4 months. I finally decided to seek your help.

Richard Schletty

Technology manager for Minnesota Association of Songwriters (MAS) – www.mnsongwriters.org 651-222-2526 office | 612-562-7324 cell | @.***

On Jul 21, 2022, at 4:53 PM, Michael Beil @.***> wrote:

@rschletty https://github.com/rschletty I am working with you on your ticket to troubleshoot this. I hope we can figure out what’s happening soon.

— Reply to this email directly, view it on GitHub https://github.com/strangerstudios/pmpro-recurring-emails/issues/24#issuecomment-1191972288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75ZIDY7S6NGIIPLDYW6DDVVHBHFANCNFSM54I6NKLA. You are receiving this because you were mentioned.

rschletty commented 2 years ago

Do we even need the recurring notification template? Would the regular Expiring template handle both fixed term and recurring notifications? I am not clear about this.

Richard Schletty

schlettydesign.com • schlettysound.com • catholicliturgyinsong.org • topcatholicsongs.com @.*** cell 612-562-7324

On Jul 21, 2022, at 5:35 PM, Richard Schletty @.***> wrote:

Much thanks, Michael. We have been perplexed by this for about 4 months. I finally decided to seek your help.

Richard Schletty

Technology manager for Minnesota Association of Songwriters (MAS) – www.mnsongwriters.org http://www.mnsongwriters.org/ 651-222-2526 office | 612-562-7324 cell | @. @.>

On Jul 21, 2022, at 4:53 PM, Michael Beil @. @.>> wrote:

@rschletty https://github.com/rschletty I am working with you on your ticket to troubleshoot this. I hope we can figure out what’s happening soon.

— Reply to this email directly, view it on GitHub https://github.com/strangerstudios/pmpro-recurring-emails/issues/24#issuecomment-1191972288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75ZIDY7S6NGIIPLDYW6DDVVHBHFANCNFSM54I6NKLA. You are receiving this because you were mentioned.

andrewlimaza commented 1 year ago

@rschletty this integration only will handle recurring members (without an expiration date), you would need to run both the Extra Expirations as well as this integration if you have variations of your pricing.

rschletty commented 1 year ago

4 month delay in responding! We have long since solved the issue.

Richard Schletty

Schletty Design • schlettydesign.com Schletty Sound • schlettysound.com @.*** cell 612-562-7324

On Nov 24, 2022, at 5:33 AM, Andrew Lima @.***> wrote: @rschletty https://github.com/rschletty this integration only will handle recurring members (without an expiration date), you would need to run both the Extra Expirations as well as this integration if you have variations of your pricing.

— Reply to this email directly, view it on GitHub https://github.com/strangerstudios/pmpro-recurring-emails/issues/24#issuecomment-1326326977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75ZIHTI2Q3FRGY3F3DF5LWJ5HA7ANCNFSM54I6NKLA. You are receiving this because you were mentioned.

andrewlimaza commented 1 year ago

As mentioned we don't actively monitor all of our Add On issues for support requests and things may take a bit of time before we get to it depending on the severity of the bug, issue or feature request.

Overlooking this issue, the !!enddate!! variable is available, but you should rather use the !!renewaldate!! variable as outlined by this code - https://github.com/strangerstudios/pmpro-recurring-emails/blob/dev/pmpro-recurring-emails.php#L204

The reason I recommend using !!renewaldate!! is that most likely the customer won't have an expiration date and receive these emails that's why it returns 1 January 1970 as it's trying to cast a NULL value to a valid date. We will be working on a fix for this in the near future as I am working on this Add On to fix some bugs.