When payment is "pending" do not assign roles.

[becleung]

Adds some code in the after_all_level_changes function using pmpropbc_isMemberPending to prevent new roles from being assigned to user.

All Submissions:

• [x] Have you followed the Contributing guideline?
• [x] Does your code follow the WordPress' coding standards?
• [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Stops new roles from being assigned when membership is pending from using the Pay By Check add-on. This partially resolves issue #36. I say partially because this does not assign roles when payment is marked "success".

How to test the changes in this Pull Request:

1. Install Pay By Check add-on
2. Check out with a new membership level, use the "pay by check" option for payment
3. The new member that signed up using "pay by check" will now only have their old role(s) instead of being automatically assigned all the new roles that comes with their new membership level

Other information:

• [x] Have you added an explanation of what your changes do and why you'd like us to include them?
• [ ] Have you successfully run tests with your changes locally?

Changelog entry

ENHANCEMENT: when membership is pending, the pending member will only be assigned old roles. New roles will not be assigned.

[andrewlimaza]

Thanks for this contribution @becleung, we have reworked the Pay By Check Add On logic and it now supports this out of the box. You may update to the latest version of Pay By Check by downloading it here - https://www.paidmembershipspro.com/add-ons/pmpro-pay-by-check-add-on/ (or updating it on your WordPress site through the admin dashboard).

Please let us know if you still face issues with the latest version.