strangerstudios / pmpro-woocommerce

Connect Paid Memberships Pro with WooCommerce and WooCommerce Subscriptions to sell membership products and offer members-only product discounts.
https://www.paidmembershipspro.com/add-ons/pmpro-woocommerce/
46 stars 32 forks source link

WooCommerce Subscription renewal payments reset membership start date #198

Closed dwanjuki closed 6 months ago

dwanjuki commented 10 months ago

Describe the bug When a subscription renewal payment is made, membership startdate is reset. PMPro series progress is lost as a result.

To Reproduce Steps to reproduce the behavior:

  1. Create a subscription product that grants a membership level then buy it.
  2. Navigate to WooCommerce > Subscriptions and note the subscription ID.
  3. Navigate to WooCommerce > Status > Scheduled Actions, search for the subscription ID and run the scheduled subscription payment.
  4. Check the Membership Level History.
  5. See that a new entry is created in level history with current day as start date.

Expected behavior No change in level start date on renewal.

Isolating the problem (mark completed items with an [x]):

WordPress Environment

PMPro 2.12.3 PMPro WooCommerce 1.8 WooCommerce 8.2.0 WooCommerce Subscriptions 5.4.0 WooCommerce Stripe 7.6.0 WP 6.3.2 PHP 8.0.30
kimcoleman commented 8 months ago

Adding additional info here - the version used to confirm this issue was Stripe - WooCommerce 7.6.0: https://wordpress.org/plugins/woocommerce-gateway-stripe/

The current version is 7.8.0.

andrewlimaza commented 6 months ago

@dwanjuki I've tested this again today by following the steps outlined above, can you confirm you are still facing this issue with the latest versions of PMPro and Woo (I can't replicate it)?

My setup:

PMPro 2.12.10, PMPro Woo 1.8, Woo Stripe 8.0.0, Woo Subscriptions 5.4.0, PHP 7.4

andrewlimaza commented 6 months ago

I'm attaching some screenshots for reference here as we might visit this later on:

Screenshot 2024-03-05 at 15 47 49 Screenshot 2024-03-05 at 15 47 57 Screenshot 2024-03-05 at 15 48 51

I had cancelled my level 1 manually, then created a daily subscription product that gives me level 1 ($5 at signup and $5 recurring). I backdated the order by a day and a bit and ran the subscription scheduled action for that particular subscription and the level stayed unchanged. (Ignore the start date of the level, I was looking for row items in the Member History to confirm this was triggering).

dwanjuki commented 6 months ago

I cannot replicate the issue anymore. The existing level remains unchanged/no new entries.

Tested on WP 6.4.3, PMPro 2.12.10, WooCommerce 8.6.1, PMPro Woo 1.8, Woo Stripe 8.0.0, Woo Subscriptions 5.4.0, PHP 8.0.30

andrewlimaza commented 6 months ago

Thanks for confirming, I'm closing this one out.