Adding new settings to hide the sale entirely by role or membership level - Githubissues

strangerstudios / sitewide-sales

Run Black Friday, Cyber Monday, or other flash sales on your WordPress-powered eCommerce or membership site with WooCommerce, Easy Digital Downloads, and Paid Memberships Pro.

https://sitewidesales.com

GNU General Public License v3.0

3 stars 6 forks source link

Adding new settings to hide the sale entirely by role or membership level #137

Closed kimcoleman closed 1 year ago

kimcoleman commented 1 year ago

All Submissions:

[x] Have you followed the Contributing guideline?
[x] Does your code follow the WordPress' coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds two new settings to hide the sale by role or by membership level. This will unset the sale's is_running check.

Also adjusted a check for displaying the banner if not hidden to any levels.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run tests with your changes locally?

Changelog entry

ENHANCEMENT: Added setting to hide sale by membership level in PMPro module.
ENHANCEMENT: Added setting to hide sale by role or for logged out users in all modules.
BUG FIX: Fixed display issue with banner when not set to hide for any roles.

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.