Memory issue on sites with many coupons.

ideadude commented 1 year ago

Describe the bug

Ran into an issue on a WooCommerce site that had 33,000+ coupons. The new sale page would fail with an out of memory issue. Looking into it, it seemed to be due to the query to get the coupons for the WC dropdown.

To Reproduce Steps to reproduce the behavior:

Somehow put 33k coupons in your site.
Use less than 500mb RAM for your admin user.
Try to create a coupon.
Choose WC from the dropdown.

Notice none of the other fields are loading... because the page should fatal error out.

Suggestions

We should perhaps do a custom query here that just gets the coupon code and ID from the posts table, since (I think) those are the only values we need.

Alternatively, updating the args here to include a few performance-related ones helps: https://github.com/strangerstudios/sitewide-sales/blob/dev/modules/ecommerce/wc/class-swsales-module-wc.php#L88-L94

$args = array(
    'posts_per_page'   => -1,
    'orderby'          => 'title',
    'order'            => 'asc',
    'post_type'        => 'shop_coupon',
    'post_status'      => 'publish',
    //new args below here:
    'nopaging' => true,
    'no_found_rows' => true,
    'update_post_meta_cache' => false,
    'update_post_term_cache' => false
);

Isolating the problem (mark completed items with an [x]):

[x] I have deactivated other plugins and confirmed this bug occurs when only the Sitewide Sales and relevant module plugins are active.
[x] This bug happens with a default WordPress theme active, or Memberlite.
[x] I can reproduce this bug consistently using the steps above.

mircobabini commented 1 year ago

Advanced docs:

kimcoleman commented 1 year ago

The updates in the PR attached to this issue have been pushed to a site that was experiencing the issue and its still not working very swiftly. What alternatives can we consider?

Filter to optionally "disable" the autocomplete/dropdown and set a secific coupon by ID?
Other ideas?

strangerstudios / sitewide-sales

Memory issue on sites with many coupons. #138