strangerstudios / sitewide-sales

Run Black Friday, Cyber Monday, or other flash sales on your WordPress-powered eCommerce or membership site with WooCommerce, Easy Digital Downloads, and Paid Memberships Pro.
https://sitewidesales.com
GNU General Public License v3.0
2 stars 6 forks source link

Sale period settings refactor #167

Closed briansantos10 closed 2 months ago

briansantos10 commented 9 months ago

All Submissions:

Changes proposed in this Pull Request:

Refactored blocks by restructuring code files. Incorporated new sale period setting block through modifying 'includes/blocks.php' and 'webpack.config'. Introduced a separate folder in 'sources' for new block files. Transferred code from 'blocks/block.js' and 'blocks/block.php' to individual files within the new block folder.

How to test the changes in this Pull Request:

  1. Make sure there is a sitewide sale active
  2. insert group block
  3. Go under advanced tab to look for sale period setting

Other information:

The block is supposed to a add sale period setting under the advanced tab for container blocks like a group block. However, this setting doesn't show up at all. This block doesn't have a edit or save component. It also doesn't have any JSON settings, so I am unsure about what files to include for the block and what code to put into those files.

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

  • Modifcations to blocks.php and webpack.config.js
  • New src/sale-period-setting folder with block files