strangerstudios / sitewide-sales

Run Black Friday, Cyber Monday, or other flash sales on your WordPress-powered eCommerce or membership site with WooCommerce, Easy Digital Downloads, and Paid Memberships Pro.
https://sitewidesales.com
GNU General Public License v3.0
2 stars 6 forks source link

Formatting strike prices for accessibility; improvement to WC pricing to use new is_type function #92

Closed kimcoleman closed 2 years ago

kimcoleman commented 2 years ago

All Submissions:

Changes proposed in this Pull Request:

Accessibility changes to how we show strikethrough pricing in Easy Digital Downloads module using recommends from accessibility expert Amber Hinds.

Note also updates to use the is_type function in WooCommerce to check product type before showing strikethrough pricing. We are not including subscription products at this time - in the future if we do include these here is a reference on product types for subscriptions: https://www.businessbloomer.com/woocommerce-check-if-product-is-subscription/.

$product->is_type( 'subscription' ) and $product->is_type( 'variable-subscription' )

Resolves #84 Resolves #73

Other information:

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.